Turn off debug build for TSAN, fixes #48031 #48210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this will be a solution. Debug build gives you much better information and backtraces. |
|
This is just a band-aid fix, as the current TSAN-enabled Julia doesn't build at all. Of course the best solution would be to fix the assertions. Until that is done, this will prevent people running into the same problem as me. |
|
Are you able to build with TSAN? |
|
|
Zentrik
added a commit
to Zentrik/julia-buildkite
that referenced
this pull request
Apr 5, 2024
I removed building julia in debug mode as JuliaLang/julia#48210 switched TSAN to defaulting to building in release mode as debug didn't work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can now build TSAN-enabled Julia on 1.9.0-beta2. Before, with debug build mode on, I hit some assertions. Fixes #48031.
cc @vtjnash @gbaraldi.